v1.1.17

README.md

@@ -4,9 +4,9 @@
 
 A firefox addon that generates a password and copies it to the clipboard
 
-![pwgen reloaded in action](img/screenshot.png)
+![pwgen reloaded in action](img/cast.gif)
 
 ## install
 
 On amo!  
-[https://addons.mozilla.org/firefox/addon/pwgen-reloaded/](https://addons.mozilla.org/firefox/addon/pwgen-reloaded/)
+[https://addons.mozilla.org/firefox/addon/pwgen-reloaded/](https://addons.mozilla.org/firefox/addon/pwgen-reloaded/)

src/manifest.json

@@ -2,7 +2,7 @@
   "description": "Just a toolbar button that generates a password and copies it to your clipboard.",
   "manifest_version": 2,
   "name": "pwgen reloaded",
-  "version": "1.1.11",
+  "version": "1.1.17",
   "homepage_url": "https://github.com/S2-/pwgen",
   "icons": {
     "48": "icons/lock-48.png"

src/popup/pwgen.html

@@ -15,12 +15,14 @@
   <form>
 
     <div>
-      <label for"length">length <input type="number" id="length" value="14" min="0" name="length"></label>
+      <label>length</label>
+      <label for="length-min">min <input type="number" id="length-min" value="14" min="0" name="length-min" style="width: 50px;"></label>
+      <label for="length-max">max <input type="number" id="length-max" value="18" min="0" name="length-max" style="width: 50px;"></label>
     </div>
 
     <div>
       <input type="checkbox" id="special" checked="checked" name="special">
-      <label for"special">include special chars</label>
+      <label for="special">include special chars</label>
     </div>
 
     <div>

src/popup/pwgen.js

@@ -14,9 +14,14 @@ function randPassword(length, includeSpecial) {
   return randPwd;
 }
 
+function generateLength() {
+  return Math.floor(Math.random() * (getParams().lengthMax - getParams().lengthMin + 1) + getParams().lengthMin);
+}
+
 function getParams() {
   return {
-    length: parseInt(document.getElementById('length').value),
+    lengthMin: parseInt(document.getElementById('length-min').value),
+    lengthMax: parseInt(document.getElementById('length-max').value),
     special: document.getElementById('special').checked,
     directcopy: document.getElementById('directcopy').checked
   }
@@ -24,7 +29,8 @@ function getParams() {
 
 function loadOptions() {
   return browser.storage.local.get({
-    length: 14,
+    lengthMin: 14,
+    lengthMax: 17,
     special: true,
     directcopy: false
   });
@@ -57,7 +63,7 @@ function fade(element) {
 
   setTimeout(() => {
     clone.remove();
-  }, 1100);
+  }, 1600);
 }
 
 document.addEventListener('DOMContentLoaded', function() {
@@ -65,7 +71,7 @@ document.addEventListener('DOMContentLoaded', function() {
   document.getElementById('new').addEventListener('click', (ev) => {
     ev.preventDefault();
     var params = getParams();
-    document.getElementById('pw').value = randPassword(params.length, params.special);
+    document.getElementById('pw').value = randPassword(generateLength(), params.special);
   });
 
   document.getElementById('copy').addEventListener('click', (ev) => {
@@ -81,10 +87,11 @@ document.addEventListener('DOMContentLoaded', function() {
   }
 
   loadOptions().then((options) => {
-    document.getElementById('length').value = options.length;
+    document.getElementById('length-min').value = options.lengthMin;
+    document.getElementById('length-max').value = options.lengthMax;
     document.getElementById('special').checked = options.special;
     document.getElementById('directcopy').checked = options.directcopy;
-    document.getElementById('pw').value = randPassword(getParams().length, getParams().special);
+    document.getElementById('pw').value = randPassword(generateLength(), getParams().special);
 
     if (options.directcopy) {
       copypasstoclippboard();