add eslint

.eslintrc.json

@@ -0,0 +1,120 @@
+{
+	"parserOptions": {
+		"ecmaVersion": 6
+	},
+	"rules": {
+		"quotes": [
+			2,
+			"single",
+			{
+				"allowTemplateLiterals": true
+			}
+		],
+		"curly": [
+			2,
+			"all"
+		],
+		"keyword-spacing": [
+			2,
+			{
+				"overrides": {
+					"else": {
+						"before": true
+					},
+					"catch": {
+						"before": true,
+						"after": false
+					}
+				}
+			}
+		],
+		"space-before-blocks": [
+			2,
+			"always"
+		],
+		"wrap-iife": [
+			2,
+			"inside"
+		],
+		"space-before-function-paren": [
+			2,
+			"never"
+		],
+		"one-var": [
+			2,
+			"never"
+		],
+		"vars-on-top": 0,
+		"no-empty": [
+			2,
+			{
+				"allowEmptyCatch": true
+			}
+		],
+		"array-bracket-spacing": [
+			2,
+			"never"
+		],
+		"space-in-parens": [
+			2,
+			"never"
+		],
+		"no-underscore-dangle": 0,
+		"comma-style": [
+			2,
+			"last"
+		],
+		"comma-spacing": [
+			2,
+			{
+				"before": false,
+				"after": true
+			}
+		],
+		"space-unary-ops": [
+			2,
+			{
+				"words": false,
+				"nonwords": false
+			}
+		],
+		"no-multi-spaces": 2,
+		"space-infix-ops": 2,
+		"no-with": 2,
+		"indent": [
+			2,
+			"tab",
+			{
+				"SwitchCase": 1,
+				"FunctionExpression": {
+					"body": 1,
+					"parameters": 1
+				},
+				"MemberExpression": 0
+			}
+		],
+		"no-mixed-spaces-and-tabs": 2,
+		"no-trailing-spaces": 2,
+		"comma-dangle": [
+			2,
+			"never"
+		],
+		"semi": [2, "always"],
+		"brace-style": [
+			2,
+			"1tbs",
+			{
+				"allowSingleLine": true
+			}
+		],
+		"eol-last": 2,
+		"dot-notation": 0,
+		"no-multi-str": 2,
+		"key-spacing": [
+			2,
+			{
+				"afterColon": true
+			}
+		]
+	}
+}

README.md

@@ -10,3 +10,13 @@ A firefox addon that generates a password and copies it to the clipboard
 
 On amo!  
 [https://addons.mozilla.org/firefox/addon/pwgen-reloaded/](https://addons.mozilla.org/firefox/addon/pwgen-reloaded/)
+
+
+## develop
+
+Clone this repo, open firefox on [about:debugging](about:debugging) and load the extension by selecting the cloned folder.  
+Start coding!
+
+## make a release
+
+zip the src folder and upload to https://addons.mozilla.org/

src/manifest.json

@@ -2,8 +2,13 @@
   "description": "Just a toolbar button that generates a password and copies it to your clipboard.",
   "manifest_version": 2,
   "name": "pwgen reloaded",
-  "version": "1.1.18",
+  "version": "1.1.23",
   "homepage_url": "https://github.com/S2-/pwgen",
+  "applications": {
+    "gecko": {
+      "id": "{46b66c4d-605f-4f4d-8689-20b44b45656c}"
+    }
+  },
   "icons": {
     "48": "icons/lock-48.png"
   },

src/popup/pwgen.css

@@ -1,65 +1,74 @@
 body {
-  margin: 15px;
+	margin: 15px;
 }
 
 div {
-  margin-top: 5px;
+	margin-top: 5px;
 }
 
 input[type="number"] {
-  -moz-appearance: none;
+	-moz-appearance: none;
-  color: var(--in-content-text-color);
+	color: var(--in-content-text-color);
-  border: 1px solid var(--in-content-box-border-color);
+	border: 1px solid var(--in-content-box-border-color);
-  -moz-border-top-colors: none !important;
+	-moz-border-top-colors: none !important;
-  -moz-border-right-colors: none !important;
+	-moz-border-right-colors: none !important;
-  -moz-border-bottom-colors: none !important;
+	-moz-border-bottom-colors: none !important;
-  -moz-border-left-colors: none !important;
+	-moz-border-left-colors: none !important;
-  border-radius: 2px;
+	border-radius: 2px;
-  background-color: var(--in-content-box-background);
+	background-color: var(--in-content-box-background);
 
-  font-family: inherit;
+	font-family: inherit;
-  font-size: inherit;
+	font-size: inherit;
-  padding: 5px 10px;
+	padding: 5px 10px;
 
-  width: 50px;
+	width: 50px;
 }
 
 #length-min {
-  margin-right: 10px;
+	margin-right: 10px;
 }
 
 input[type="checkbox"] {
-  margin-bottom: -7px;
+	margin-bottom: -7px;
 }
 
 #pw {
-  border: 2px black solid;
+	border: 2px black solid;
-  width: 250px;
+	width: 250px;
 }
 
 #copy {
-  margin-left: 0px;
+	margin-left: 0px;
+}
+
+#exclude {
+	width: 183px;
 }
 
 .copied {
-  /*height: 100%;*/
+	pointer-events: none;
-  width: 100%;
+	height: 26px;
-  background-color: #FFF8DC;
+	width: 100%;
-  position: absolute;
+	background-color: #FFF8DC;
-  margin: -25px;
+	position: absolute;
-  margin-top: -5px;
+	padding-right: 0;
-  padding: 5px;
+	padding-left: 0;
-  text-align: center;
+	padding-top: 5px;
+	padding-bottom: 5px;
+	text-align: center;
+	margin-right: -15px;
+	margin-left: -19px;
+	margin-top: -27px;
 }
 
 .fadein {
-  visibility: visible;
+	visibility: visible;
-  opacity: 1;
+	opacity: 1;
-  transition: opacity 1s linear;
+	transition: opacity 1s linear;
 }
 
 .fadeout {
-  visibility: hidden;
+	visibility: hidden;
-  opacity: 0;
+	opacity: 0;
-  transition: visibility 0s 1s, opacity 1s linear;
+	transition: visibility 0s 1s, opacity 1s linear;
 }

src/popup/pwgen.html

@@ -1,46 +1,50 @@
 <!DOCTYPE html>
 <html>
-  <head>
+	<head>
-    <meta charset="utf-8">
+		<meta charset="utf-8">
-    <meta name="viewport" content="width=device-width, initial-scale=1">
+		<meta name="viewport" content="width=device-width, initial-scale=1">
-    <link rel="stylesheet" href="chrome://global/skin/global.css" type="text/css" />
+		<link rel="stylesheet" href="chrome://global/skin/global.css" type="text/css" />
-    <link rel="stylesheet" href="chrome://global/skin/in-content/common.css" type="text/css" />
+		<link rel="stylesheet" href="chrome://global/skin/in-content/common.css" type="text/css" />
 
-    <link rel="stylesheet" href="pwgen.css"/>
+		<link rel="stylesheet" href="pwgen.css"/>
-  </head>
+	</head>
 
 <body>
-  <div class="copied" style="display: none;">Password copied to clipboard</div>
+	<form>
+		<div>
+			<input type="text" id="pw" name="pw">
+		</div>
 
-  <form>
+		<div>
-    <div>
+			<label>Length: </label>
-      <input type="text" id="pw" name="pw">
+			<label for="length-min">min.</label> <input type="number" id="length-min" value="14" min="0" name="length-min">
-    </div>
+			<label for="length-max">max.</label> <input type="number" id="length-max" value="18" min="0" name="length-max">
+		</div>
 
-    <div>
+		<div>
-      <label>Length: </label>
+			<input type="checkbox" id="special" checked="checked" name="special">
-      <label for="length-min">min.</label> <input type="number" id="length-min" value="14" min="0" name="length-min">
+			<label for="special">Include special characters</label>
-      <label for="length-max">max.</label> <input type="number" id="length-max" value="18" min="0" name="length-max">
+		</div>
-    </div>
 
-    <div>
+		<div>
-      <input type="checkbox" id="special" checked="checked" name="special">
+			<label for="exclude">Exclude: </label>
-      <label for="special">Include special characters</label>
+			<input type="text" id="exclude" name="exclude">
-    </div>
+		</div>
 
-    <div>
+		<div>
-      <button id="copy">Copy to clipboard</button><button id="new">Generate another</button>
+			<button id="copy">Copy to clipboard</button><button id="new">Generate another</button>
-    </div>
+		</div>
 
-    <hr>
+		<hr>
 
-    <div>
+		<div>
-      <input type="checkbox" id="directcopy" name="directcopy" title="The next time the toolbar button is clicked, the password is copied to the clipboard directly">
+			<input type="checkbox" id="directcopy" name="directcopy" title="The next time the toolbar button is clicked, the password is copied to the clipboard directly">
-      <label for="directcopy">Copy directly</label>
+			<label for="directcopy">Copy directly</label>
-    </div>
+			<div class="copied" style="display: none;">Password copied to clipboard</div>
+		</div>
 
-  </form>
+	</form>
-  <script src="pwgen.js"></script>
+	<script src="pwgen.js"></script>
 </body>
 
 </html>

src/popup/pwgen.js

@@ -1,101 +1,113 @@
-function randPassword(length, includeSpecial) {
+function randPassword(length, includeSpecial, exclude) {
-  let pwdChars = "0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz";
+	let pwdChars = '0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz';
-  if (includeSpecial) {
+	if (includeSpecial) {
-    pwdChars += '°^!"§$%&/()=?`´\\}][{²³€|<>-.,;:*+_µ@~';
+		pwdChars += '!"#$%&\'()*+,-./:;<=>?@[\]^_`{|}~';
-  }
+	}
 
-  let randValues = new Uint32Array(length);
+	if (exclude) {
-  let randPwd = '';
+		exclude.split('').forEach(c => {
-  window.crypto.getRandomValues(randValues);
+			pwdChars = pwdChars.split(c).join('');
-  for(i=0; i<length; i++)
+		});
-  {
+	}
-    randPwd += pwdChars[randValues[i] % pwdChars.length];
+
-  }
+	let randValues = new Uint32Array(length);
-  return randPwd;
+	let randPwd = '';
+	window.crypto.getRandomValues(randValues);
+	for (i = 0; i < length; i++) {
+		randPwd += pwdChars[randValues[i] % pwdChars.length];
+	}
+	return randPwd;
 }
 
 function generateLength() {
-  return Math.floor(Math.random() * (getParams().lengthMax - getParams().lengthMin + 1) + getParams().lengthMin);
+	return Math.floor(Math.random() * (getParams().lengthMax - getParams().lengthMin + 1) + getParams().lengthMin);
 }
 
 function getParams() {
-  return {
+	return {
-    lengthMin: parseInt(document.getElementById('length-min').value),
+		lengthMin: parseInt(document.getElementById('length-min').value),
-    lengthMax: parseInt(document.getElementById('length-max').value),
+		lengthMax: parseInt(document.getElementById('length-max').value),
-    special: document.getElementById('special').checked,
+		special: document.getElementById('special').checked,
-    directcopy: document.getElementById('directcopy').checked
+		exclude: document.getElementById('exclude').value,
-  }
+		directcopy: document.getElementById('directcopy').checked
+	};
 }
 
 function loadOptions() {
-  return browser.storage.local.get({
+	return browser.storage.local.get({
-    lengthMin: 14,
+		lengthMin: 14,
-    lengthMax: 17,
+		lengthMax: 17,
-    special: true,
+		special: true,
-    directcopy: false
+		exclude: 'iIl|10o8B3Evu![]{}',
-  });
+		directcopy: false
+	});
 }
 
 function saveOptions(options) {
-  return browser.storage.local.set(options);
+	return browser.storage.local.set(options);
 }
 
 function copypasstoclippboard(cb) {
-  setTimeout(function() {
+	setTimeout(function() {
-    var copyText = document.getElementById('pw');
+		var copyText = document.getElementById('pw');
-    copyText.select();
+		copyText.select();
-    document.execCommand('copy');
+		document.execCommand('copy');
-    if (typeof(cb) === 'function') {
+		if (typeof(cb) === 'function') {
-      cb();
+			cb();
-    }
+		}
-    fade(document.getElementsByClassName('copied')[0]);
+		fade(document.getElementsByClassName('copied')[0]);
-  }, 200);
+	}, 200);
 }
 
 function fade(element) {
-  var clone = element.cloneNode(true);
+	var clone = element.cloneNode(true);
-  clone.style.display = 'block';
+	clone.style.display = 'block';
-  element.parentNode.insertBefore(clone, element.nextSibling);
+	element.parentNode.insertBefore(clone, element.nextSibling);
 
-  setTimeout(() => {
+	setTimeout(() => {
-    clone.className += ' fadeout';
+		clone.className += ' fadeout';
-  }, 500);
+	}, 500);
 
-  setTimeout(() => {
+	setTimeout(() => {
-    clone.remove();
+		clone.remove();
-  }, 1600);
+	}, 1600);
 }
 
 document.addEventListener('DOMContentLoaded', function() {
 
-  document.getElementById('new').addEventListener('click', (ev) => {
+	document.getElementById('new').addEventListener('click', (ev) => {
-    ev.preventDefault();
+		ev.preventDefault();
-    var params = getParams();
+		var params = getParams();
-    document.getElementById('pw').value = randPassword(generateLength(), params.special);
+		document.getElementById('pw').value = randPassword(generateLength(), params.special, params.exclude);
-  });
 
-  document.getElementById('copy').addEventListener('click', (ev) => {
+		if (params.directcopy) {
-    ev.preventDefault();
+			copypasstoclippboard();
-    copypasstoclippboard();
+		}
-  });
+	});
 
-  var list = document.getElementsByTagName('input');
+	document.getElementById('copy').addEventListener('click', (ev) => {
-  for (var i = 0; i < list.length; i++) {
+		ev.preventDefault();
-    list[i].addEventListener('change', (ev) => {
+		copypasstoclippboard();
-      saveOptions(getParams());
+	});
-    });
-  }
 
-  loadOptions().then((options) => {
+	var list = document.getElementsByTagName('input');
-    document.getElementById('length-min').value = options.lengthMin;
+	for (var i = 0; i < list.length; i++) {
-    document.getElementById('length-max').value = options.lengthMax;
+		list[i].addEventListener('change', (ev) => {
-    document.getElementById('special').checked = options.special;
+			saveOptions(getParams());
-    document.getElementById('directcopy').checked = options.directcopy;
+		});
-    document.getElementById('pw').value = randPassword(generateLength(), getParams().special);
+	}
 
-    if (options.directcopy) {
+	loadOptions().then((options) => {
-      copypasstoclippboard();
+		document.getElementById('length-min').value = options.lengthMin;
-    }
+		document.getElementById('length-max').value = options.lengthMax;
-  });
+		document.getElementById('special').checked = options.special;
+		document.getElementById('exclude').value = options.exclude;
+		document.getElementById('directcopy').checked = options.directcopy;
+		document.getElementById('pw').value = randPassword(generateLength(), getParams().special, getParams().exclude);
+
+		if (options.directcopy) {
+			copypasstoclippboard();
+		}
+	});
 
 });